🐛 Handle missing account for order and ticket notifications

Prevent NoMethodError when an order's account is nil in the orders controller. Ensure that ticket notifications are only sent if an account is present. This improves the robustness of the application by gracefully handling scenarios where an associated account might be missing.

🐛 (stripe_charge.rb): Add guard clause for nil application fee

Add a guard clause to the ticket_revenue_to_revenue_sharer method. This ensures that if application_fee_amount is nil, the method returns Money.new(0, currency) immediately. Prevents potential errors when application_fee_amount is not set, making the calculation more robust.

🐛 Fix revenue calculation for zero application fees and balance

Previously, revenue calculation methods incorrectly returned zero when both application_fee_amount and balance were zero. This happened because the conditional check balance > 0 && application_fee_amount_money > 0 evaluated to false, leading to a zero fallback.

This commit introduces a specific handling for the application_fee_amount == 0 && balance == 0 case. Now, in this scenario, the methods correctly return the base revenue or donation amount instead of zero, ensuring accurate reporting.

🐛 Fix calculation for zero application fees

Removed redundant && application_fee_amount > 0 from if conditions. The previous condition caused calculations to fall into the else block when application_fee_amount was 0. This was incorrect as the else block is intended for cases where no application fee mechanism is present. The updated condition if application_fee_amount ensures that if an application fee exists (even if its value is zero), the fee-based calculation path is taken. The subsequent check application_fee_amount_money > 0 within the ternary operator then correctly yields Money.new(0, currency) when the fee amount is zero, preventing miscalculations and ensuring accurate revenue reporting.

🎨 (Gemfile): Reorganize gem declarations for better categorization

Moves the crawler_detect gem from the "Everything else" section to the "Rack" section. This improves the logical grouping and readability of the Gemfile by placing related gems together.

🎨
➖
💡 Refactor Gemfile for clarity and remove matrix gem

Move maxmind-geoip2 to the main dependency list. Add comments to utility gems to explain their purpose. Remove matrix gem as it is no longer a required dependency.

🐛 (delayed_job_error_notifications.rb): Send full error string to Honeybadger context

The last_error is now passed directly to Honeybadger's context without splitting it by newlines. This ensures that the complete error message, including any multi-line details or backtraces, is preserved and sent for more comprehensive error reporting and debugging.

♻️ Move Stripe webhook URL definition to respective models

Move the stripe_webhook_url method from the StripeWebhooks concern to the Gathering and Organisation models.

This removes conditional logic from the shared concern, making the webhook URL definition explicit within each model. It improves code clarity and adheres better to the Single Responsibility Principle.

🐛 (belongs_to_without_parent_validation): Validate in-memory parent

Add check for in-memory parent object before querying the database. This ensures validations pass for unsaved associated records, particularly with nested attributes, by recognizing objects present in memory. It also reduces unnecessary database queries.

♻️
🔥 Remove DandelionModel and inline Mongoid concerns

Removed the DandelionModel base class. Inlined Mongoid::Document, Mongoid::Timestamps, and BelongsToWithoutParentValidation modules directly into all models that previously inherited from it. This simplifies the model inheritance hierarchy, making each model's dependencies explicit and reducing an unnecessary layer of abstraction.

🎨 (dandelion_model.rb): Automate Mongoid collection naming for subclasses

Remove self.abstract_class = true as it is not applicable to Mongoid. Implement an inherited hook to automatically set the MongoDB collection name for subclasses. This ensures that all models inheriting from DandelionModel will have their collection name derived from their class name, reducing boilerplate and enforcing a consistent naming convention.

🏗️ (dandelion_model.rb): Mark DandelionModel as an abstract class

Prevents direct instantiation of the base model. Ensures it serves solely as a parent for other models.

✨ (models): introduce DandelionModel as a base class for Mongoid models
✨ (models): introduce BelongsToWithoutParentValidation concern to skip parent validation
♻️ (models): refactor models to inherit from DandelionModel and use new belongs_to
⬆️ (Gemfile): update Mongoid gem to allow newer versions

♻️ perf(event_boost_bid): index event association for performance

Adding an index to the event_id field improves query performance when looking up EventBoostBid records by their associated event.

✨ (organisations/_events.erb): Make event pagination per_page configurable

The per_page option for event pagination now accepts a params[:per_page] value. This provides greater flexibility for users to control the number of events displayed on a page, overriding the default of 20.

♻️ Refactor event feedback associations and view logic

Removes the direct 'activity_id' association from EventFeedback and related callbacks. EventFeedback is now implicitly linked to an Activity through its Event, simplifying the data model and reducing redundancy. This eliminates the need for manual 'activity_id' updates and ensures data consistency.

Also removes the 'unscoped: true' local variable from event feedback partials and the corresponding 'unscoped' check within the partial. The responsibility for providing scoped or unscoped feedback collections is now solely with the calling controller or model, simplifying view logic.

🎨 (events): Use h4 for question headings

Change label tag to h4 for questions prefixed with '#'. This improves the semantic structure and visual hierarchy. Questions now appear as distinct headings, enhancing readability.